Skip to content

add hide param for prometheus query (needed by __expr__ query to the datasource) #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

peekjef72
Copy link
Contributor

Description

see #205

Checklist

  • The patch has appropriate test coverage
  • The patch follows the style guidelines of this project
  • The patch has appropriate comments, particularly in hard-to-understand areas
  • The documentation was updated corresponding to the patch
  • [x ] I have performed a self-review of this patch

Signed-off-by: peekjf72 <jfpik78@gmail.com>
@peekjef72 peekjef72 requested a review from amotl as a code owner January 26, 2025 12:08
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.29%. Comparing base (ea15cf9) to head (188f6e1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files          27       27           
  Lines        1816     1816           
=======================================
  Hits         1676     1676           
  Misses        140      140           
Flag Coverage Δ
unittests 92.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peekjef72
Copy link
Contributor Author

Hi Andreas
Hope you are fine.
Just a very small fix, that probably needs to be propagated to other datasources, but i'm not sure.
JFPIK-

Copy link
Contributor

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oha. Thank you very much! 👍

@amotl amotl merged commit 717f203 into main Jan 26, 2025
7 checks passed
@amotl amotl deleted the prometheus_ds branch January 26, 2025 22:36
@amotl
Copy link
Contributor

amotl commented Jan 26, 2025

We just released version 4.2.3 including your fix. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants