Fix MCP server mounted path #11231
Merged
Fix MCP server mounted path #11231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/a78ef0fbfaaced256c955afe546962765f724cc5/gradio-5.30.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@a78ef0fbfaaced256c955afe546962765f724cc5#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/a78ef0fbfaaced256c955afe546962765f724cc5/gradio-client-1.15.0.tgzUse Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/a78ef0fbfaaced256c955afe546962765f724cc5/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
freddyaboulton
approved these changes
May 21, 2025
| @@ -157,6 +157,7 @@ async def handle_sse(request): | |||
| streams[1], | |||
| self.mcp_server.create_initialization_options(), | |||
| ) | |||
| return Response() | |||
There was a problem hiding this comment.
Why do we need this? Is it possible to even reach this part of the code? The with block seems like it would block forever
There was a problem hiding this comment.
Yeah so I added it because I would see an exception being raised (None type is not callable or something like that) when a client would disconnect from the mcp server. So while it doesn't functionally change anything, it prevents this exception from being raised during disconnect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mcp==1.9.0introduced a breaking change in how paths are mounted (the new approach is actually the correct one, see modelcontextprotocol/python-sdk#659)This PR makes the corresponding change in Gradio's MCP server to account for this change and adds a test.
Closes: #11225
Closes: #11219