DRAFT PR: Default the WAV audio recorder to 1 channel/mono (Issue #903) #917
Conversation
…ly for defiend demods. (Issue gqrx-sdr#903)
|
Probably needs rework, because I'm not sure about the intended behaviour of the recorder, when switching demodulators while active recording... that has to be defined: a) auto restart recorder in all cases Any suggestions? |
| break; | ||
|
|
||
| case RX_DEMOD_WFM_S_OIRT: | ||
| connect_all(RX_CHAIN_WFMRX); | ||
| rx->set_demod(wfmrx::WFMRX_DEMOD_STEREO_UKW); | ||
| d_is_stereo_type_demodulator = true; | ||
| break; | ||
|
|
||
| case RX_DEMOD_SSB: |
There was a problem hiding this comment.
RX_DEMOD_NONE produces 2 channels and needs d_is_stereo_type_demodulator = true (it is raw IQ)
| @@ -1000,11 +1004,11 @@ receiver::status receiver::start_audio_recording(const std::string filename) | |||
| // if this fails, we don't want to go and crash now, do we | |||
| try { | |||
| #if GNURADIO_VERSION < 0x030900 | |||
| wav_sink = gr::blocks::wavfile_sink::make(filename.c_str(), 2, | |||
| wav_sink = gr::blocks::wavfile_sink::make(filename.c_str(), d_is_stereo_type_demodulator ? 2 : 1, | |||
There was a problem hiding this comment.
mey-be rename d_is_stereo_type_demodulator to somethink like d_demod_channels and set directly to 1 or 2?
I would go for new file each time the demod is changed. The reasoning is as follow:
Changing output format for audio UDP stream will probably break receiving app, so althought inconsistent probably should stay in stereo mode all the time (just duplicate the mono). Considering all the fuss, I'm not 100% sure the saved space is worth the complexity, but I guess this should be best proven by the code. |
Defaults the WAV audio recorder to 1 channel/mono, recoding stereo only for defined demods. (Issue #903)