Fix inaccessible audio device crash #1105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladisslav2011
force-pushed
the
audiodev_crash
branch
2 times, most recently
from
51ec044 to
2d7e0f1
Compare
Throw an exception form pa_sink::pa_sink Better exceptions handling in receiver::set_output_device Set conf_ok to false in MainWindow::loadConfig if rx->set_output_device fails.
vladisslav2011
force-pushed
the
audiodev_crash
branch
from
2d7e0f1 to
0bb0c05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw an exception form pa_sink::pa_sink
Better exceptions handling in receiver::set_output_device
Set conf_ok to false in MainWindow::loadConfig if
rx->set_output_device fails.
Test results:
Linux, Gr-audio - PASSED
Linux, Pulseaudio - PASSED
Linux, Portaudio - PASSED
Portaudio backend does not trigger the crash in case of bad device name. It just selects default audio device in that case...
Close #1102