Skip to content

feat: fix onReady, onMoovStart and onSidx callbacks typing #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: fix onReady, onMoovStart and onSidx callbacks typing #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/isofile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,11 @@ export class ISOFile<TSegmentUser = unknown, TSampleUser = unknown> {
/** Boolean used to fire moov start event only once */
moovStartFound = false;
/** Callback called when the moov parsing starts */
onMoovStart = null;
onMoovStart: (() => void) | null = null;
/** Boolean keeping track of the call to onMoovStart, to avoid double calls */
moovStartSent = false;
/** Callback called when the moov is entirely parsed */
onReady = null;
onReady: ((info: Movie) => void) | null = null;
/** Boolean keeping track of the call to onReady, to avoid double calls */
readySent = false;
/** Callback to call when segments are ready */
Expand Down Expand Up @@ -195,7 +195,7 @@ export class ISOFile<TSegmentUser = unknown, TSampleUser = unknown> {
/** Boolean indicating if the initial list of items has been produced */
itemListBuilt = false;
/** Callback called when the sidx box is entirely parsed */
onSidx = null;
onSidx: ((sidx: sidxBox) => void) | null = null;
/** Boolean keeping track of the call to onSidx, to avoid double calls */
sidxSent = false;

Expand Down