-
Notifications
You must be signed in to change notification settings - Fork 351
Add ESLint #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESLint #455
Conversation
First commit will disappear if #454 is merged |
Thanks for the PR. Couple comments though:
Also the linting doesn't seem to run on our CI (and on my local setup). Could you check that please? |
Most seems fixed @DenizUgur
Not sure about this one, could you please elaborate? Maybe the current state is fine? |
Was it fixed with the new imports from |
Thank you @erwanvivien |
🎉 This PR is included in version 0.6.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Adds ESLint to the repo (used with
npm run lint
)Linting greatly improves DX and potentially the future PRs thanks to a bit more strictness