Skip to content

Add ESLint #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 27, 2025
Merged

Add ESLint #455

merged 16 commits into from
May 27, 2025

Conversation

erwanvivien
Copy link
Contributor

Description

Adds ESLint to the repo (used with npm run lint)

Linting greatly improves DX and potentially the future PRs thanks to a bit more strictness

@erwanvivien
Copy link
Contributor Author

First commit will disappear if #454 is merged

@DenizUgur
Copy link
Member

Thanks for the PR. Couple comments though:

  • I would prefer if we follow tseslint's recommendations: https://typescript-eslint.io/getting-started
  • We should use the prettier plugin
  • No need to test js files (or anything other than ts or json)
  • We should have a single RuleConfig for TS files and one for JSON
  • We need ESLint to check both entries/ and src/ folders

Also the linting doesn't seem to run on our CI (and on my local setup). Could you check that please?

@erwanvivien erwanvivien mentioned this pull request May 26, 2025
@erwanvivien
Copy link
Contributor Author

Most seems fixed @DenizUgur

We should have a single RuleConfig for TS files and one for JSON

Not sure about this one, could you please elaborate? Maybe the current state is fine?

@erwanvivien
Copy link
Contributor Author

Also the linting doesn't seem to run on our CI

Was it fixed with the new imports from tseslint.configs.strict & tseslint.configs.stylistic

@DenizUgur
Copy link
Member

Thank you @erwanvivien

@DenizUgur DenizUgur merged commit 99dd2b5 into gpac:next May 27, 2025
4 checks passed
Copy link

🎉 This PR is included in version 0.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants