Parse meta box and related boxes in in QTFF format #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To get the test to pass, a video file is necessary. I am getting permission from the photographer for the video to be included in the test suite. |
In the QTFF format (ie: Quicktime .MOV files) the 'meta' atom has is a container box instead of a full box. We add a flag on the stream to indicate this difference in behavior once we know we are parsing a QTFF format file. Fixes gpac#309
This includes these atoms/boxes: * 'keys' which are the named keys in a QTFF 'meta' box * 'ilst' which typically follows the 'keys' atom within 'meta' * 'data' usually the the contents of an ilst atom The 'data' box has many data types. Each type is described by the enumeration ItifTypes. Only support for those that have a test file have been implemented so far: * UTF8 * BE_UNSIGNED_INT * BE_SIGNED_INT * BE_FLOAT32
iphone.movHere is the file necessary to get the test suite to pass. I have permission from the photographer to use it here:
|
|
Could you please re-open this PR for the |
|
@DenizUgur I'm working on this. How do I get the tests to work. QUnit based tests seems to have been removed (from package.json). What has replaced it? |
|
Nothing has replaced it yet. I'm planning on adding a new testsuite but until then you don't need to worry about the tests. |
|
Worked on this here #459 ... a few more tasks related to testing needed, but broadly ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the QTFF format (ie: Quicktime .MOV files) the 'meta' atom
has is a container box instead of a full box. We add a flag
on the stream to indicate this difference in behavior once we
know we are parsing a QTFF format file.
This includes these atoms/boxes:
The 'data' box has many data types. Each type is described by the
enumeration ItifTypes. Only support for those that have a test
file have been implemented so far: