fix requirements #72
Open
fix requirements #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goru001 Please merge this |
|
Thanks @Ishan-Kumar2 for your contribution. Can you share a notebook showing the issue which this PR tries to solve? I was not able to reproduce the issue which you seem to be referring to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The requirements mentioned in the
setup.pyfile includetypingwhich is redundant as it is included in the stdlib from python 3.5 onwards see here. Since iNLTK supports only Python >=3.6 installing typing causes an error. Also sklearn which is needed has been included.Let me know if I am wrong. Thanks!