perf: Cache posts in redux store or performance #86
Conversation
src/state/ducks/posts/actions.js
Outdated
| }; | ||
|
|
||
| export { | ||
| // eslint-disable-next-line import/prefer-default-export |
There was a problem hiding this comment.
don't need this line anymore when exporting multiple variables
src/state/ducks/posts/selectors.js
Outdated
|
|
||
| const getHomePosts = state => sortBy => ( | ||
| sort(Object.values(state.posts.home), sortBy) | ||
| ); |
There was a problem hiding this comment.
simpler way
const getHomePosts = state => sortBy => sort(Object.values(state.posts.home), sortBy);do the same for the others
src/state/ducks/posts/selectors.js
Outdated
| sort(Object.values(state.posts.saved), sortBy) | ||
| ); | ||
|
|
||
| const getSourcePosts = state => (sortBy, source) => ( |
There was a problem hiding this comment.
the source param is required but the sortBy is optional, so we should put the source to the front
src/state/ducks/posts/selectors.js
Outdated
| ); | ||
|
|
||
| const getSourcePosts = state => (sortBy, source) => ( | ||
| state.posts.sources[source] ? sort(state.posts.sources, sortBy, source) : 0 |
There was a problem hiding this comment.
should return an empty array instead of 0
There was a problem hiding this comment.
and why don't we just pass state.posts.sources[source] instead of sort(state.posts.sources, ... !?
the solution should be sort(state.posts.sources[source] || [], sortBy)
and refactoring the sort function is needed for this change. The sort function is just for sorting an inputted posts array, so only 2 params (posts, sortBy) are required.
src/components/Home/Home.render.js
Outdated
| const title = source ? source.title : 'Explore'; | ||
|
|
||
| return <Home title={title} source={source} {...rest} />; | ||
| return <Home title={title} source={source} {...rest} match={match} />; |
There was a problem hiding this comment.
we don't need to pass match to Home props anymore because I extracted the source id (source) from it already in
const source = match.params.source ? getSource(match.params.source) : undefined;
return <Home title={title} source={source} {...rest} />;There was a problem hiding this comment.
maybe you just need to change source to sourceId
const sourceId = match.params.sourceId ? getSource(match.params.sourceId) : undefined;
return <Home title={title} sourceId={sourceId} {...rest} />;
No description provided.