Skip to content
This repository was archived by the owner on Jul 29, 2022. It is now read-only.

Allow php5 to fail #40

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Allow php5 to fail #40

merged 1 commit into from
Oct 7, 2020

Conversation

gorghoa
Copy link
Owner

@gorghoa gorghoa commented Oct 7, 2020

Travis’ builds are failing on php5, blocking some useful PR.

Allowing them to fail.

Copy link
Collaborator

@vincentchalamon vincentchalamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP 5.6 is not supported anymore since end of 2018 (almost 2 years). I would remove PHP5 from the tests

@vincentchalamon
Copy link
Collaborator

Duplicate from #39

@gorghoa
Copy link
Owner Author

gorghoa commented Oct 7, 2020

@vincentchalamon, I agree with the objective.

The difference with #39 is that this PR does not imply major version change (no BC break), just fix a CI failure. #39 will imply a major version bump.

I just want to be able to merge #38 without @magarzon to suffer a build failure.

@vincentchalamon
Copy link
Collaborator

vincentchalamon commented Oct 7, 2020

Removing PHP5 from the CI is not a BC break. I would better just remove PHP5 from the CI, but not from the composer.json

@gorghoa
Copy link
Owner Author

gorghoa commented Oct 7, 2020

Nope, but #39 will require a php version >= 7.x (in composer.json), hence requiring a major version bump IMO

Removing PHP5 from the CI is not a BC break. I would better just remove PHP5 from the CI, but not from the composer.json

That’s the point. I want to tag a minor release version compatible with php5.6 and allowing symfony 5

Then, I want to tag a new major version requiring a more recent php version, dropping all unsupported php version.tests.

Copy link
Collaborator

@vincentchalamon vincentchalamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s the point. I want to tag a minor release version compatible with php5.6 and allowing symfony 5

OK I see. So LGTM!

Then, I want to tag a new major version requiring a more recent php version, dropping all unsupported php version.tests.

It's not only about bumping the php version from the composer.json file, I think it would require some code improvement to PHP7.

@gorghoa gorghoa merged commit 68d8975 into master Oct 7, 2020
@gorghoa
Copy link
Owner Author

gorghoa commented Oct 7, 2020

thanks :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants