Skip to content

Conversation

markmandel
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:

  • Add 'Wasm' as a new policy type option for FleetAutoscaler
  • Create reusable 'url.configuration' template for webhook and wasm URL configs
  • Add wasm policy schema with function, config, from.url, and hash fields
  • Refactor webhook policy to use shared url.configuration template
  • Update generated install.yaml with corresponding CRD changes

Which issue(s) this PR fixes:

Work on #4080

Special notes for your reviewer:

N/A

@github-actions github-actions bot added the kind/feature New features for Agones label Oct 6, 2025
@github-actions github-actions bot added the size/M label Oct 6, 2025
@markmandel markmandel added area/operations Installation, updating, metrics etc and removed size/M labels Oct 6, 2025
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: c0e35baa-b2ce-4218-8c3d-a88273258a59

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4298/head:pr_4298 && git checkout pr_4298
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-5a71b18

Copy link
Collaborator

@lacroixthomas lacroixthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the spaces, LGTM !

- type: integer
- type: string
webhook:
webhook:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why it added these spaces, I don't see them on the template

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly - no idea. Code gen add them 🤷🏻 I can't see any good reason why.

@markmandel markmandel enabled auto-merge (squash) October 14, 2025 18:41
@markmandel markmandel disabled auto-merge October 14, 2025 18:41
- Add 'Wasm' as a new policy type option for FleetAutoscaler
- Create reusable 'url.configuration' template for webhook and wasm URL configs
- Add wasm policy schema with function, config, from.url, and hash fields
- Refactor webhook policy to use shared url.configuration template
- Update generated install.yaml with corresponding CRD changes

Work on googleforgames#4080
@markmandel markmandel force-pushed the feature/wasm-autoscaler-yaml-crds branch from 5a71b18 to d8f0f5b Compare October 14, 2025 22:30
@markmandel markmandel enabled auto-merge (squash) October 14, 2025 22:31
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: dffcdfa9-fe21-4a47-8344-fa381a45fe29

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4298/head:pr_4298 && git checkout pr_4298
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-d8f0f5b

@markmandel markmandel merged commit 9b7f01d into googleforgames:main Oct 15, 2025
4 checks passed
@markmandel markmandel deleted the feature/wasm-autoscaler-yaml-crds branch October 15, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/operations Installation, updating, metrics etc kind/feature New features for Agones size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants