-
Notifications
You must be signed in to change notification settings - Fork 867
Add Wasm autoscaler policy support to FleetAutoscaler CRDs YAML #4298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wasm autoscaler policy support to FleetAutoscaler CRDs YAML #4298
Conversation
Build Succeeded 🥳 Build Id: c0e35baa-b2ce-4218-8c3d-a88273258a59 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the spaces, LGTM !
- type: integer | ||
- type: string | ||
webhook: | ||
webhook: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why it added these spaces, I don't see them on the template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly - no idea. Code gen add them 🤷🏻 I can't see any good reason why.
- Add 'Wasm' as a new policy type option for FleetAutoscaler - Create reusable 'url.configuration' template for webhook and wasm URL configs - Add wasm policy schema with function, config, from.url, and hash fields - Refactor webhook policy to use shared url.configuration template - Update generated install.yaml with corresponding CRD changes Work on googleforgames#4080
5a71b18
to
d8f0f5b
Compare
Build Succeeded 🥳 Build Id: dffcdfa9-fe21-4a47-8344-fa381a45fe29 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Work on #4080
Special notes for your reviewer:
N/A