This repository was archived by the owner on Apr 22, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 897
Support for IETF ABNF (RFC 5234 and extensions) #542
Open
reschke
wants to merge
7
commits into
googlearchive:master
Choose a base branch
from
reschke:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9f4e7db
Support for IETF ABNF (RFC 5234 and extensions)
reschke acd3dfe
make base URI point to clone
reschke 567f9a9
Revert "make base URI point to clone"
reschke e245b3f
add comments on the nature of the extensions, and also support %i in …
reschke d8a2671
slightly improve range/concatenation expressions
reschke 2606f27
fix date
reschke 7616def
- refactor literal parsing
reschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
/** | ||
* @license | ||
* Copyright (C) 2008 Julian Reschke | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
/** | ||
* @fileoverview | ||
* Registers a language handler for IETF ABNF, as specified in RFC 5234, | ||
* and extended in RFCs 7230 and 7405. | ||
*/ | ||
|
||
PR['registerLangHandler']( | ||
PR['createSimpleLexer']( | ||
[ | ||
// comment | ||
[PR['PR_COMMENT'], /;[^\r\n]*/, null, ";"], | ||
], | ||
[ | ||
// string, binary, decimal and hex literals | ||
[PR['PR_LITERAL'], /((\%s)?"[^"]*"|(\%x[A-Za-z0-9]+(-[A-Za-z0-9]+|[\.[A-Za-z0-9]+]*))|(\%d[0-9]+(-[0-9]+|[\.[0-9]+]*))|(\%b[01]+(-[01]+|[\.[01]+]*)))/, null], | ||
// prose rule | ||
[PR['PR_PLAIN'], /<[^<>]*>/, null], | ||
// rule name | ||
[PR['PR_KEYWORD'], /([A-Za-z][A-Za-z0-9-]*)/, null], | ||
[PR['PR_PUNCTUATION'], /[=\(\)\*\/\[\]#]/, null], | ||
]), | ||
['ietfabnf']); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure
(-[A-Za-z0-9]+|[\.[A-Za-z0-9]+]*)
doesn't do what you want. Notice the[
and]
around\.[A-Za-z0-9]+
instead of parentheses.Maybe
(?:[-.][A-Za-z0-9]+)*
does what you want.If so, this problem occurs thrice.
Also, AFAICT,
%s
doesn't appear in RFC 5234. Is that part of an extension? Do those conventions include an escaping convention for strings?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to address this in d8a2671 - note that the simplified expression would match things like
%x31-39-49
which it should not (but then one could argue that it's not the job of the highlighter to spot errors like these).