chore(toolbox-core): deprecate add_headers feature #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twishabansal
changed the title
twishabansal
changed the title
twishabansal
changed the title
anubhav756
previously approved these changes
Jun 11, 2025
anubhav756
previously approved these changes
Jun 11, 2025
Fixed the tests |
anubhav756
approved these changes
Jun 11, 2025
anubhav756
previously approved these changes
Jun 11, 2025
anubhav756
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only want to allow users to add headers during client initialization. There is no clear intended behaviour for the headers.
Users are expected to use a client to connect to a single toolbox server. So, adding
client_headersduring Client initialization is the simpler path that avoids confusion.So, we remove the
add_headersmethod.