fix(toolbox-core): Prevent ToolboxClient from closing externally managed client sessions

packages/toolbox-core/src/toolbox_core/client.py

@@ -33,6 +33,7 @@ class ToolboxClient:
 
     __base_url: str
     __session: ClientSession
+    __manage_session: bool
 
     def __init__(
         self,
@@ -56,7 +57,9 @@ def __init__(
         self.__base_url = url
 
         # If no aiohttp.ClientSession is provided, make our own
+        self.__manage_session = False
         if session is None:
+            self.__manage_session = True
             session = ClientSession()
         self.__session = session
 
@@ -142,10 +145,10 @@ async def close(self):
         any tools created by this Client to cease to function.
 
         If the session was provided externally during initialization, the caller
-        is responsible for its lifecycle, but calling close here will still
-        attempt to close it.
+        is responsible for its lifecycle.
         """
-        await self.__session.close()
+        if self.__manage_session:
+            await self.__session.close()
 
     async def load_tool(
         self,

packages/toolbox-core/src/toolbox_core/sync_client.py

@@ -66,10 +66,6 @@ def close(self):
         """
         Synchronously closes the underlying client session. Doing so will cause
         any tools created by this Client to cease to function.
-
-        If the session was provided externally during initialization, the caller
-        is responsible for its lifecycle, but calling close here will still
-        attempt to close it.
         """
         coro = self.__async_client.close()
         asyncio.run_coroutine_threadsafe(coro, self.__loop).result()