Skip to content

feat(toolbox_core): add helper methods for retrieving ID tokens #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
May 16, 2025
Merged

feat(toolbox_core): add helper methods for retrieving ID tokens #239

merged 19 commits into from
May 16, 2025

Conversation

twishabansal
Copy link
Contributor

@twishabansal twishabansal commented May 12, 2025 •
edited
Loading

Allows users to connect with authenticated services which use Google ID tokens.

User experience:

from toolbox_core import auth_methods

auth_token_provider = auth_methods.aget_google_id_token # can also use sync method
toolbox = ToolboxClient(
    URL,
    client_headers={"Authorization": auth_token_provider},
)
tools = await toolbox.load_toolset()

Support for other auth mechanisms are not in scope right now.
Contributions are welcome!

@twishabansal twishabansal requested a review from a team as a code owner May 12, 2025 08:59
@kurtisvg kurtisvg changed the title feat: add toolbox_auth_methods module feat(toolbox_core): add helper methods for retrieving ID tokens May 12, 2025
kurtisvg
kurtisvg requested changes May 12, 2025
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please include documentation for this?

@twishabansal
Copy link
Contributor Author

Can we please include documentation for this?

Added docs and tests.

@twishabansal twishabansal requested a review from kurtisvg May 13, 2025 06:23
kurtisvg
kurtisvg approved these changes May 16, 2025
View reviewed changes
@twishabansal twishabansal merged commit b3213cc into main May 16, 2025
19 checks passed
@release-please release-please bot mentioned this pull request May 16, 2025
Merged
@twishabansal twishabansal deleted the twisha-auth-methods branch May 16, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

@anubhav756 anubhav756 Awaiting requested review from anubhav756

Assignees

@kurtisvg kurtisvg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twishabansal @kurtisvg