fix(toolbox-core)!: Throw PermissionError on unauthenticated tool invocation #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubhav756
changed the title
twishabansal
approved these changes
May 11, 2025
anubhav756
force-pushed
the
anubhav-typevar
branch
from
3d2a5dc to
8cf0a15
Compare
anubhav756
force-pushed
the
anubhav-perm-error
branch
from
d12c73e to
7c61263
Compare
kurtisvg
approved these changes
May 12, 2025
anubhav756
force-pushed
the
anubhav-typevar
branch
from
8cf0a15 to
28dec3e
Compare
anubhav756
force-pushed
the
anubhav-perm-error
branch
from
7c61263 to
4b52872
Compare
anubhav756
force-pushed
the
anubhav-typevar
branch
from
28dec3e to
6d95619
Compare
anubhav756
force-pushed
the
anubhav-perm-error
branch
from
4b52872 to
09c0de1
Compare
anubhav756
force-pushed
the
anubhav-typevar
branch
from
6d95619 to
eb5d2d4
Compare
anubhav756
force-pushed
the
anubhav-perm-error
branch
from
09c0de1 to
090a02a
Compare
anubhav756
force-pushed
the
anubhav-typevar
branch
from
eb5d2d4 to
85e5eba
Compare
This change introduces a warning that is displayed immediately before a tool invocation if: 1. The invocation includes an authentication header. 2. The connection is being made over non-secure HTTP. > [!IMPORTANT] The purpose of this warning is to alert the user to the security risk of sending credentials over an unencrypted channel and to encourage the use of HTTPS.
anubhav756
force-pushed
the
anubhav-perm-error
branch
from
090a02a to
c6e67f5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier a
ValueErrorwas being thrown. In case of unauthenticated tool calls, aPermissionErroris more suitable.