fix: Fix issue causing masking of empty loop or thread check while loading tool/toolset #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubhav756
changed the title
anubhav756
force-pushed
the
anubhav-sync-tool-test
branch
from
98f6dd4 to
a7d2335
Compare
anubhav756
force-pushed
the
anubhav-sync-client-loop
branch
from
10be78b to
3d7d713
Compare
kurtisvg
approved these changes
May 12, 2025
anubhav756
force-pushed
the
anubhav-sync-tool-test
branch
from
a7d2335 to
2226405
Compare
anubhav756
force-pushed
the
anubhav-sync-client-loop
branch
from
3d7d713 to
2e77464
Compare
anubhav756
force-pushed
the
anubhav-sync-tool-test
branch
from
2226405 to
d7d171d
Compare
This change introduces a warning that is displayed immediately before a tool invocation if: 1. The invocation includes an authentication header. 2. The connection is being made over non-secure HTTP. > [!IMPORTANT] The purpose of this warning is to alert the user to the security risk of sending credentials over an unencrypted channel and to encourage the use of HTTPS.
…ading tool/toolset
anubhav756
force-pushed
the
anubhav-sync-client-loop
branch
from
2e77464 to
f3a1865
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove an unused
type: ignorecomment.