Skip to content

chore: Add unit tests for ToolboxSyncTool #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 14, 2025
Merged

chore: Add unit tests for ToolboxSyncTool #224

merged 8 commits into from
May 14, 2025

Conversation

anubhav756
Copy link
Contributor

@anubhav756 anubhav756 commented May 6, 2025 •
edited
Loading 

Name                              Stmts   Miss  Cover
-----------------------------------------------------
src/toolbox_core/__init__.py          3      0   100%
src/toolbox_core/client.py          102      0   100%
src/toolbox_core/protocol.py         32      0   100%
src/toolbox_core/sync_client.py      41     25    39%
src/toolbox_core/sync_tool.py        38      0   100%
src/toolbox_core/tool.py             95      0   100%
src/toolbox_core/utils.py            37      0   100%
-----------------------------------------------------

Note

Unit test coverage for sync_tool.py is added in #225.

@anubhav756 anubhav756 self-assigned this May 6, 2025
@anubhav756 anubhav756 requested a review from a team as a code owner May 6, 2025 12:41
@anubhav756 anubhav756 marked this pull request as draft May 6, 2025 12:43
@anubhav756 anubhav756 marked this pull request as ready for review May 7, 2025 10:20
@anubhav756 anubhav756 force-pushed the anubhav-http-warn branch from 83c6763 to 691adfb Compare May 12, 2025 14:13
@anubhav756 anubhav756 force-pushed the anubhav-sync-tool-test branch from 98f6dd4 to a7d2335 Compare May 12, 2025 14:13
@anubhav756 anubhav756 force-pushed the anubhav-http-warn branch from 691adfb to 0f45b69 Compare May 13, 2025 10:04
@anubhav756 anubhav756 force-pushed the anubhav-sync-tool-test branch from a7d2335 to 2226405 Compare May 13, 2025 10:31
Base automatically changed from anubhav-http-warn to main May 13, 2025 14:45
anubhav756 added 8 commits May 14, 2025 17:19
@anubhav756
chore: Add unit test cases
c5e0727
@anubhav756
chore: Delint
5039ff9
@anubhav756
feat: Warn on insecure tool invocation with authentication
359f0b6 
This change introduces a warning that is displayed immediately before a tool invocation if:
1. The invocation includes an authentication header.
2. The connection is being made over non-secure HTTP.

> [!IMPORTANT]
The purpose of this warning is to alert the user to the security risk of sending credentials over an unencrypted channel and to encourage the use of HTTPS.
@anubhav756
fix!: Warn about https only during tool initialization
8b14783
@anubhav756
chore: Add unit tests for ToolboxSyncTool
3181002
@anubhav756
fix: Fix unittest failing due to mock attaching wrong spec signature …
8358c2a 
…while asserting
@anubhav756
fix: Use correct name property while creating sync tool qualname
bf88ca7
@anubhav756
chore: Add unit tests for @Property methods
d7d171d
@anubhav756 anubhav756 force-pushed the anubhav-sync-tool-test branch from 2226405 to d7d171d Compare May 14, 2025 11:51
@anubhav756 anubhav756 merged commit 787ba5d into main May 14, 2025
19 checks passed
@anubhav756 anubhav756 deleted the anubhav-sync-tool-test branch May 14, 2025 12:24
@release-please release-please bot mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

@twishabansal twishabansal Awaiting requested review from twishabansal

Assignees

@anubhav756 anubhav756

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anubhav756 @kurtisvg