fix(toolbox-core)!: Standardize on ValueError for improved error consistency #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubhav756
force-pushed
the
anubhav-refactor-auth-header
branch
from
7e5d768 to
4fbe671
Compare
kurtisvg
approved these changes
May 8, 2025
anubhav756
force-pushed
the
anubhav-refactor-auth-header
branch
from
4fbe671 to
e6396b6
Compare
anubhav756
changed the title
Post adding the feature of adding client-level auth headers (#178), we have the logic for creating an auth header, from the given auth token getter name, in 3 different places. This PR unifies all of that logic into a single helper to improve maintenance, and make it easier to change the way we add suffix/prefix, and reduces WET code.
…sistency This PR updates instances where generic `Exception` objects were thrown in `toolbox-core` to use `ValueError` instead. This aligns with the prevalent use of `ValueError` for argument-related issues elsewhere in the package, leading to more specific, predictable, and robust error handling for consumers of `toolbox-core`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates instances where generic
Exceptionobjects were thrown intoolbox-coreto useValueErrorinstead.This aligns with the prevalent use of
ValueErrorfor argument-related issues elsewhere in the package, leading to more specific, predictable, and robust error handling for consumers oftoolbox-core.