feat: Add client headers to Toolbox #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/toolbox-core/src/toolbox_core/client.py # packages/toolbox-core/src/toolbox_core/tool.py
kurtisvg
approved these changes
Apr 21, 2025
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
This has been done in another PR: ca88369. I just edited the import statement. However, it's interesting that even with the wrong import in I replicated this PR locally and no tests fail. but @anubhav756 do you have any ideas why? |
Merged
This was referenced Apr 22, 2025
anubhav756
added a commit
that referenced
this pull request
May 5, 2025
Post adding the feature of adding client-level auth headers (#178), we have the logic for creating an auth header, from the given auth token getter name, in 3 different places. This PR unifies all of that logic into a single helper to improve maintenance, and make it easier to change the way we add suffix/prefix, and reduces WET code.
anubhav756
added a commit
that referenced
this pull request
May 5, 2025
Post adding the feature of adding client-level auth headers (#178), we have the logic for creating an auth header, from the given auth token getter name, in 3 different places. This PR unifies all of that logic into a single helper to improve maintenance, and make it easier to change the way we add suffix/prefix, and reduces WET code.
anubhav756
added a commit
that referenced
this pull request
May 5, 2025
Post adding the feature of adding client-level auth headers (#178), we have the logic for creating an auth header, from the given auth token getter name, in 3 different places. This PR unifies all of that logic into a single helper to improve maintenance, and make it easier to change the way we add suffix/prefix, and reduces WET code.
anubhav756
added a commit
that referenced
this pull request
May 12, 2025
Post adding the feature of adding client-level auth headers (#178), we have the logic for creating an auth header, from the given auth token getter name, in 3 different places. This PR unifies all of that logic into a single helper to improve maintenance, and make it easier to change the way we add suffix/prefix, and reduces WET code.
anubhav756
added a commit
that referenced
this pull request
May 12, 2025
* chore: Add unit test coverage. * chore: Consolidate auth header creation logic Post adding the feature of adding client-level auth headers (#178), we have the logic for creating an auth header, from the given auth token getter name, in 3 different places. This PR unifies all of that logic into a single helper to improve maintenance, and make it easier to change the way we add suffix/prefix, and reduces WET code. * chore: Delint * chore: Delint
anubhav756
added a commit
that referenced
this pull request
May 12, 2025
Post adding the feature of adding client-level auth headers (#178), we have the logic for creating an auth header, from the given auth token getter name, in 3 different places. This PR unifies all of that logic into a single helper to improve maintenance, and make it easier to change the way we add suffix/prefix, and reduces WET code.
anubhav756
added a commit
that referenced
this pull request
May 12, 2025
…istency (#219) * chore: Add unit test coverage. * chore: Consolidate auth header creation logic Post adding the feature of adding client-level auth headers (#178), we have the logic for creating an auth header, from the given auth token getter name, in 3 different places. This PR unifies all of that logic into a single helper to improve maintenance, and make it easier to change the way we add suffix/prefix, and reduces WET code. * chore(toolbox-core): Standardize on ValueError for improved error consistency This PR updates instances where generic `Exception` objects were thrown in `toolbox-core` to use `ValueError` instead. This aligns with the prevalent use of `ValueError` for argument-related issues elsewhere in the package, leading to more specific, predictable, and robust error handling for consumers of `toolbox-core`. * chore: Delint * chore: Remove duplicate test
anubhav756
added a commit
that referenced
this pull request
May 12, 2025
Post adding the feature of adding client-level auth headers (#178), we have the logic for creating an auth header, from the given auth token getter name, in 3 different places. This PR unifies all of that logic into a single helper to improve maintenance, and make it easier to change the way we add suffix/prefix, and reduces WET code.
anubhav756
added a commit
that referenced
this pull request
May 12, 2025
* chore: Add unit test coverage. * chore: Consolidate auth header creation logic Post adding the feature of adding client-level auth headers (#178), we have the logic for creating an auth header, from the given auth token getter name, in 3 different places. This PR unifies all of that logic into a single helper to improve maintenance, and make it easier to change the way we add suffix/prefix, and reduces WET code. * docs: Add names to return values for better readability * chore: Improve readability * chore: Remove redundant tests * feat: Introduce identifying used authz token getters This PR adds the feature in `identify_required_authn_params` helper to determine which of the provided auth token getters are actively used to satisfy a tool's authorization requirements (as defined by the `authRequired` key in its manifest). This is a foundational step towards future validation in `ToolboxTool.add_auth_token_getters`, which will ensure no configured auth token getters remain unused, thereby preventing potential misconfigurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
Client Headersfeature, which allows users to bind certain headers to the client. These headers will be used in every subsequent request sent through the client.add_headersmethod toToolboxClient.ToolboxClientinit.This would allow us to deploy Toolbox Server securely to various deployment environments like Cloud Run and connect using Authorization.
For more information, see Toolbox Cloud Run Authentication.
Note: I'll add the same feature in the Sync Client in a following PR.