-
Notifications
You must be signed in to change notification settings - Fork 15
feat: Added a sync toolbox client #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
3e6336f
create sync tool
twishabansal b6442b4
create sync client
twishabansal 2095970
add sync client and its tests
twishabansal 190ae98
lint
twishabansal fe45341
small fix
twishabansal fad580a
docs fix
twishabansal 7737c84
lint
twishabansal 5a866b9
Export sync as well as async client
twishabansal e3272ae
remove mixed implementations
twishabansal 1231006
Merge branch 'main' into twisha-sync-wrapper
twishabansal 9b8776f
fix toolbox sync client and tool name
twishabansal 5d5338d
fix default port
twishabansal c7603f2
PR comments resolve
twishabansal 50217d3
Merge remote-tracking branch 'origin/twisha-sync-wrapper' into twisha…
twishabansal 9c0d0db
small fix
twishabansal 954d7d2
Apply suggestions from code review
twishabansal 239143f
fix docstrings
twishabansal 0e370f3
Merge remote-tracking branch 'origin/twisha-sync-wrapper' into twisha…
twishabansal 351dd11
lint
twishabansal aea643b
Merge branch 'main' into twisha-sync-wrapper
twishabansal 27aa9d8
small fix
twishabansal 9ace575
resolve comment
twishabansal 360b4be
fix
twishabansal 68c82d2
Merge remote-tracking branch 'origin/twisha-sync-wrapper' into twisha…
twishabansal 033c85d
remove run_as_sync and run_as_async methods
twishabansal cacec35
lint
twishabansal 9bab4c0
lint
twishabansal d81a790
change from function attributes to properties
twishabansal dd4ebd9
fix mypy issue
twishabansal dfe7768
fix mypy issue
twishabansal a805455
lint
twishabansal c5a0cf5
remove session variable
twishabansal eb28453
lint
twishabansal d620c25
added qualname
twishabansal 9e1da13
fix qualname
twishabansal 5aaf20a
nit
twishabansal 6d0780a
Merge branch 'main' into twisha-sync-wrapper
twishabansal 1f21b36
Merge branch 'main' into twisha-sync-wrapper
twishabansal 4939a18
fix comment
twishabansal d650e1c
fix error message
twishabansal f0455a0
Merge branch 'main' into twisha-sync-wrapper
twishabansal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,149 @@ | ||
# Copyright 2025 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import asyncio | ||
from threading import Thread | ||
from typing import Any, Awaitable, Callable, Mapping, Optional, TypeVar, Union | ||
|
||
from aiohttp import ClientSession | ||
|
||
from .client import ToolboxClient | ||
from .sync_tool import ToolboxSyncTool | ||
|
||
T = TypeVar("T") | ||
|
||
|
||
class ToolboxSyncClient: | ||
""" | ||
An synchronous client for interacting with a Toolbox service. | ||
|
||
Provides methods to discover and load tools defined by a remote Toolbox | ||
service endpoint. | ||
""" | ||
|
||
__loop: Optional[asyncio.AbstractEventLoop] = None | ||
__thread: Optional[Thread] = None | ||
|
||
def __init__( | ||
self, | ||
url: str, | ||
): | ||
""" | ||
Initializes the ToolboxSyncClient. | ||
|
||
Args: | ||
url: The base URL for the Toolbox service API (e.g., "http://localhost:5000"). | ||
""" | ||
# Running a loop in a background thread allows us to support async | ||
# methods from non-async environments. | ||
if self.__class__.__loop is None: | ||
loop = asyncio.new_event_loop() | ||
thread = Thread(target=loop.run_forever, daemon=True) | ||
thread.start() | ||
self.__class__.__thread = thread | ||
self.__class__.__loop = loop | ||
|
||
async def create_client(): | ||
return ToolboxClient(url) | ||
|
||
# Ignoring type since we're already checking the existence of a loop above. | ||
self.__async_client = asyncio.run_coroutine_threadsafe( | ||
create_client(), self.__class__.__loop # type: ignore | ||
).result() | ||
|
||
def close(self): | ||
""" | ||
Synchronously closes the underlying client session. Doing so will cause | ||
any tools created by this Client to cease to function. | ||
|
||
If the session was provided externally during initialization, the caller | ||
is responsible for its lifecycle, but calling close here will still | ||
attempt to close it. | ||
""" | ||
coro = self.__async_client.close() | ||
asyncio.run_coroutine_threadsafe(coro, self.__loop).result() | ||
|
||
def load_tool( | ||
self, | ||
name: str, | ||
auth_token_getters: dict[str, Callable[[], str]] = {}, | ||
bound_params: Mapping[str, Union[Callable[[], Any], Any]] = {}, | ||
) -> ToolboxSyncTool: | ||
""" | ||
Synchronously loads a tool from the server. | ||
|
||
Retrieves the schema for the specified tool from the Toolbox server and | ||
returns a callable object (`ToolboxSyncTool`) that can be used to invoke the | ||
tool remotely. | ||
|
||
Args: | ||
name: The unique name or identifier of the tool to load. | ||
auth_token_getters: A mapping of authentication service names to | ||
callables that return the corresponding authentication token. | ||
bound_params: A mapping of parameter names to bind to specific values or | ||
callables that are called to produce values as needed. | ||
|
||
Returns: | ||
ToolboxSyncTool: A callable object representing the loaded tool, ready | ||
for execution. The specific arguments and behavior of the callable | ||
depend on the tool itself. | ||
""" | ||
coro = self.__async_client.load_tool(name, auth_token_getters, bound_params) | ||
|
||
# We have already created a new loop in the init method in case it does not already exist | ||
async_tool = asyncio.run_coroutine_threadsafe(coro, self.__loop).result() # type: ignore | ||
|
||
if not self.__loop or not self.__thread: | ||
raise ValueError("Background loop or thread cannot be None.") | ||
return ToolboxSyncTool(async_tool, self.__loop, self.__thread) | ||
|
||
def load_toolset( | ||
self, | ||
name: str, | ||
auth_token_getters: dict[str, Callable[[], str]] = {}, | ||
bound_params: Mapping[str, Union[Callable[[], Any], Any]] = {}, | ||
) -> list[ToolboxSyncTool]: | ||
""" | ||
Synchronously fetches a toolset and loads all tools defined within it. | ||
|
||
Args: | ||
name: Name of the toolset to load tools. | ||
auth_token_getters: A mapping of authentication service names to | ||
callables that return the corresponding authentication token. | ||
bound_params: A mapping of parameter names to bind to specific values or | ||
callables that are called to produce values as needed. | ||
|
||
Returns: | ||
list[ToolboxSyncTool]: A list of callables, one for each tool defined | ||
in the toolset. | ||
""" | ||
coro = self.__async_client.load_toolset(name, auth_token_getters, bound_params) | ||
|
||
# We have already created a new loop in the init method in case it does not already exist | ||
async_tools = asyncio.run_coroutine_threadsafe(coro, self.__loop).result() # type: ignore | ||
|
||
if not self.__loop or not self.__thread: | ||
raise ValueError("Background loop or thread cannot be None.") | ||
return [ | ||
ToolboxSyncTool(async_tool, self.__loop, self.__thread) | ||
for async_tool in async_tools | ||
] | ||
|
||
def __enter__(self): | ||
"""Enter the runtime context related to this client instance.""" | ||
return self | ||
|
||
def __exit__(self, exc_type, exc_val, exc_tb): | ||
"""Exit the runtime context and close the client session.""" | ||
self.close() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,142 @@ | ||
# Copyright 2025 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import asyncio | ||
from asyncio import AbstractEventLoop | ||
from inspect import Signature | ||
from threading import Thread | ||
from typing import Any, Callable, Mapping, TypeVar, Union | ||
|
||
from .tool import ToolboxTool | ||
|
||
T = TypeVar("T") | ||
|
||
|
||
class ToolboxSyncTool: | ||
""" | ||
A callable proxy object representing a specific tool on a remote Toolbox server. | ||
|
||
Instances of this class behave like synchronous functions. When called, they | ||
send a request to the corresponding tool's endpoint on the Toolbox server with | ||
the provided arguments. | ||
|
||
It utilizes Python's introspection features (`__name__`, `__doc__`, | ||
`__signature__`, `__annotations__`) so that standard tools like `help()` | ||
and `inspect` work as expected. | ||
""" | ||
|
||
def __init__( | ||
self, async_tool: ToolboxTool, loop: AbstractEventLoop, thread: Thread | ||
): | ||
""" | ||
Initializes a callable that will trigger the tool invocation through the | ||
Toolbox server. | ||
|
||
Args: | ||
async_tool: An instance of the asynchronous ToolboxTool. | ||
loop: The event loop used to run asynchronous tasks. | ||
thread: The thread to run blocking operations in. | ||
""" | ||
|
||
if not isinstance(async_tool, ToolboxTool): | ||
raise TypeError("async_tool must be an instance of ToolboxTool") | ||
|
||
self.__async_tool = async_tool | ||
self.__loop = loop | ||
self.__thread = thread | ||
|
||
# NOTE: We cannot define __qualname__ as a @property here. | ||
# Properties are designed to compute values dynamically when accessed on an *instance* (using 'self'). | ||
# However, Python needs the class's __qualname__ attribute to be a plain string | ||
# *before* any instances exist, specifically when the 'class ToolboxSyncTool:' statement | ||
# itself is being processed during module import or class definition. | ||
# Defining __qualname__ as a property leads to a TypeError because the class object needs | ||
# a string value immediately, not a descriptor that evaluates later. | ||
self.__qualname__ = f"{self.__class__.__qualname__}.{self.__name__}" | ||
|
||
@property | ||
def __name__(self) -> str: | ||
return self.__async_tool.__name__ | ||
|
||
@property | ||
def __doc__(self) -> Union[str, None]: # type: ignore[override] | ||
# Standard Python object attributes like __doc__ are technically "writable". | ||
# But not defining a setter function makes this a read-only property. | ||
# Mypy flags this issue in the type checks. | ||
return self.__async_tool.__doc__ | ||
|
||
@property | ||
def __signature__(self) -> Signature: | ||
return self.__async_tool.__signature__ | ||
|
||
@property | ||
def __annotations__(self) -> dict[str, Any]: # type: ignore[override] | ||
# Standard Python object attributes like __doc__ are technically "writable". | ||
# But not defining a setter function makes this a read-only property. | ||
# Mypy flags this issue in the type checks. | ||
return self.__async_tool.__annotations__ | ||
|
||
def __call__(self, *args: Any, **kwargs: Any) -> str: | ||
""" | ||
Synchronously calls the remote tool with the provided arguments. | ||
|
||
Validates arguments against the tool's signature, then sends them | ||
as a JSON payload in a POST request to the tool's invoke URL. | ||
|
||
Args: | ||
*args: Positional arguments for the tool. | ||
**kwargs: Keyword arguments for the tool. | ||
|
||
Returns: | ||
The string result returned by the remote tool execution. | ||
""" | ||
coro = self.__async_tool(*args, **kwargs) | ||
return asyncio.run_coroutine_threadsafe(coro, self.__loop).result() | ||
|
||
def add_auth_token_getters( | ||
self, | ||
auth_token_getters: Mapping[str, Callable[[], str]], | ||
) -> "ToolboxSyncTool": | ||
""" | ||
Registers an auth token getter function that is used for AuthServices when tools | ||
twishabansal marked this conversation as resolved.
Show resolved
Hide resolved
|
||
are invoked. | ||
|
||
Args: | ||
auth_token_getters: A mapping of authentication service names to | ||
callables that return the corresponding authentication token. | ||
|
||
Returns: | ||
A new ToolboxSyncTool instance with the specified authentication token | ||
getters registered. | ||
""" | ||
|
||
new_async_tool = self.__async_tool.add_auth_token_getters(auth_token_getters) | ||
return ToolboxSyncTool(new_async_tool, self.__loop, self.__thread) | ||
|
||
def bind_parameters( | ||
self, bound_params: Mapping[str, Union[Callable[[], Any], Any]] | ||
) -> "ToolboxSyncTool": | ||
""" | ||
Binds parameters to values or callables that produce values. | ||
|
||
Args: | ||
bound_params: A mapping of parameter names to values or callables that | ||
produce values. | ||
|
||
Returns: | ||
A new ToolboxSyncTool instance with the specified parameters bound. | ||
""" | ||
|
||
new_async_tool = self.__async_tool.bind_parameters(bound_params) | ||
return ToolboxSyncTool(new_async_tool, self.__loop, self.__thread) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.