Skip to content

fix: correct invalid reference when using array types #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

fix: correct invalid reference when using array types #128

merged 1 commit into from
Apr 3, 2025

Conversation

anubhav756
Copy link
Contributor

@anubhav756 anubhav756 commented Apr 2, 2025 •
edited
Loading

  • Fix ._items --> .items
  • Fix to_type() --> __get_type()

@anubhav756 anubhav756 self-assigned this Apr 2, 2025
@anubhav756 anubhav756 marked this pull request as ready for review April 2, 2025 12:34
@anubhav756 anubhav756 requested a review from a team as a code owner April 2, 2025 12:34
@anubhav756 anubhav756 changed the title fix: Fix nested types for array types in ParameterSchema. fix: Fix array nested type in ParameterSchema. Apr 2, 2025
@kurtisvg kurtisvg force-pushed the kvg-bound-params branch 2 times, most recently from e9e1c89 to ce82891 Compare April 2, 2025 20:57
Base automatically changed from kvg-bound-params to main April 2, 2025 21:13
kurtisvg
kurtisvg requested changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a regression test to ensure this behavior is working correctly going forward?

@kurtisvg kurtisvg changed the title fix: Fix array nested type in ParameterSchema. fix: correct invalid reference when using array types Apr 2, 2025
@anubhav756 anubhav756 force-pushed the anubhav-type-fix branch 2 times, most recently from 98d2d19 to b06e6c0 Compare April 3, 2025 08:40
@anubhav756 anubhav756 requested a review from kurtisvg April 3, 2025 08:52
kurtisvg
kurtisvg approved these changes Apr 3, 2025
View reviewed changes
@anubhav756 anubhav756 merged commit d5a3259 into main Apr 3, 2025
14 checks passed
@anubhav756 anubhav756 deleted the anubhav-type-fix branch April 3, 2025 18:41
@release-please release-please bot mentioned this pull request Apr 3, 2025
Merged
@twishabansal twishabansal mentioned this pull request Apr 3, 2025
Merged
This was referenced Apr 4, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

@twishabansal twishabansal Awaiting requested review from twishabansal

Assignees

@anubhav756 anubhav756

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anubhav756 @kurtisvg