Skip to content

feat(toolbox-core): add authenticated parameters support #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 2, 2025
Merged

feat(toolbox-core): add authenticated parameters support #119

merged 9 commits into from
Apr 2, 2025

Conversation

kurtisvg
Copy link
Contributor

@kurtisvg kurtisvg commented Mar 30, 2025 •
edited by anubhav756
Loading

Add's support for specifying token getters for use with Auth Service features.

  • ToolboxClient: adds optional auth_token_getters argument to the load_tool and load_toolset functions
  • ToolboxTool: adds add_auth_token_getters function to ToolboxTool

@kurtisvg kurtisvg requested a review from a team as a code owner March 30, 2025 17:16
@kurtisvg kurtisvg changed the title feat: add basic toolbox-core implementation feat: add authenticated parameters support Mar 30, 2025
Base automatically changed from kvg-toolbox-core-basic to main March 30, 2025 17:40
@kurtisvg kurtisvg changed the title feat: add authenticated parameters support feat(toolbox-core): add authenticated parameters support Mar 30, 2025
@kurtisvg kurtisvg force-pushed the kvg-basic-auth branch 2 times, most recently from d3d03a0 to 61d32aa Compare March 31, 2025 15:36
twishabansal
twishabansal reviewed Apr 1, 2025
View reviewed changes
@twishabansal
Copy link
Contributor

Earlier, we were allowing users to pass in auth_headers as well as auth_tokens (ref)

If we plan to remove support for auth_headers, we should mention in the release notes for toolbox-langchain and toolbox-llamaindex.

anubhav756
anubhav756 requested changes Apr 1, 2025
View reviewed changes
anubhav756
anubhav756 requested changes Apr 1, 2025
View reviewed changes
twishabansal
twishabansal requested changes Apr 1, 2025
View reviewed changes
@twishabansal twishabansal mentioned this pull request Apr 1, 2025
Merged
anubhav756
anubhav756 requested changes Apr 1, 2025
View reviewed changes
@anubhav756 anubhav756 mentioned this pull request Apr 2, 2025
Closed
@kurtisvg kurtisvg merged commit 10087a1 into main Apr 2, 2025
14 checks passed
@kurtisvg kurtisvg deleted the kvg-basic-auth branch April 2, 2025 19:46
@release-please release-please bot mentioned this pull request Apr 2, 2025
Merged
@twishabansal twishabansal mentioned this pull request Apr 3, 2025
Merged
This was referenced Apr 4, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anubhav756 anubhav756 anubhav756 approved these changes

@twishabansal twishabansal twishabansal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kurtisvg @twishabansal @anubhav756