chore: refactor wrap method helper into a macro #2111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohmayr
force-pushed
the
refactor-wrap-method-macro
branch
from
cae7e99 to
94a46f4
Compare
ohmayr
force-pushed
the
refactor-wrap-method-macro
branch
from
8c77cc0 to
af98897
Compare
parthea
approved these changes
Aug 29, 2024
vchudnov-g
requested changes
Aug 29, 2024
...ration/goldens/asset/google/cloud/asset_v1/services/asset_service/transports/grpc_asyncio.py
Outdated
Show resolved
Hide resolved
vchudnov-g
reviewed
Aug 29, 2024
...ration/goldens/asset/google/cloud/asset_v1/services/asset_service/transports/grpc_asyncio.py
Outdated
Show resolved
Hide resolved
gapic/templates/%namespace/%name_%version/%sub/services/%service/_shared_macros.j2
Outdated
Show resolved
Hide resolved
vchudnov-g
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
OK, please address the comments here about enforcing macro contracts, but otherwise LGTM now. Thanks for working on this and answering my questions!
I've updated the contract and will shortly be merging this. Thanks for the feedback! |
ohmayr
changed the title
ohmayr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
wrap_methodwith the kind property configured.