Skip to content

tools/syz-symbolize: use -config to support module symbolize #6002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

jiangenj
Copy link
Contributor

@jiangenj jiangenj commented May 6, 2025


Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md


@a-nogikh
Copy link
Collaborator

a-nogikh commented May 13, 2025

Hi Joey!

I'd suggest that we add -config as an optional parameter for syz-symbolize instead of only accepting the syz-manager-config. I.e. if flagConfig is specified, use it, otherwise rely on the remaining parameters.

The full syz-manager config, which is required by mgrconfig.LoadFile, is much larger and more rigorously checked than the small piece of it generated here for mgrconfig.LoadPartialData.

@jiangenj
Copy link
Contributor Author

@a-nogikh updated, please review again.

@a-nogikh a-nogikh added this pull request to the merge queue May 14, 2025
Merged via the queue into google:master with commit a4fa04e May 14, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants