Skip to content

Conversation

timothyba
Copy link

No description provided.

@Copilot Copilot AI review requested due to automatic review settings August 7, 2025 03:41
Copy link

google-cla bot commented Aug 7, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the size/XS Pull request with less than 50 lines changed label Aug 7, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request sets "gpt-oss:120b" as the default model for Ollama language model usage. The change introduces default model selection logic that automatically chooses appropriate models based on the language model type when no model ID is explicitly provided.

  • Updates the Ollama language model constructor to use "gpt-oss:120b" as the default model
  • Modifies the main extract function to accept None for model_id and implement automatic model selection
  • Adds logic to set default models for different language model types (Ollama, Gemini, OpenAI)

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
langextract/inference.py Sets default model_id parameter to "gpt-oss:120b" for OllamaLanguageModel constructor
langextract/init.py Changes model_id parameter to optional and adds default model selection logic based on language_model_type

@timothyba timothyba force-pushed the feature/default-ollama-model branch from fa3ffd1 to 80f0beb Compare August 7, 2025 03:42
@timothyba timothyba closed this Aug 7, 2025
@timothyba timothyba reopened this Aug 7, 2025
Copy link

github-actions bot commented Aug 7, 2025

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@timothyba timothyba closed this Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Pull request with less than 50 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant