Skip to content

Conversation

morioka
Copy link

@morioka morioka commented Jul 31, 2025

  • fix OllamaLanguageModel constructor argument name.
  • add "how to use with ollama" to README.md

Copy link

google-cla bot commented Jul 31, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@aksg87 aksg87 changed the title fix ollama issue fix ollama issue Aug 5, 2025
@aksg87
Copy link
Collaborator

aksg87 commented Aug 5, 2025

Thank you @morioka for identifying the model vs model_id parameter mismatch.

PR #57 has been created focusing solely on the parameter fix to streamline the review process, as it separates the core fix from documentation changes. Additional Ollama documentation is being prepared separately.

Your contribution in discovering this issue is valued. Please continue to share any feedback or issues you encounter with Ollama integration.

@aksg87 aksg87 closed this Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants