Update kwargs handling for provider models #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves initialization order bug where provider kwargs were lost. Runtime kwargs now properly override stored defaults. - Add merge_kwargs() to base class - Filter None values to prevent SDK errors - Support provider-specific params (stop, top_p, top_logprobs) - Add test coverage
|
Your branch is 1 commits behind git fetch origin main
git merge origin/main
git pushNote: Enable "Allow edits by maintainers" to allow automatic updates. |
aksg87
added a commit
that referenced
this pull request
Aug 21, 2025
* Fix kwargs passthrough for all providers Resolves initialization order bug where provider kwargs were lost. Runtime kwargs now properly override stored defaults. - Add merge_kwargs() to base class - Filter None values to prevent SDK errors - Support provider-specific params (stop, top_p, top_logprobs) - Add test coverage * Update OpenAI JSON mode to not require fence output
sinnaj
pushed a commit
to sinnaj/langextract
that referenced
this pull request
Sep 3, 2025
* Fix kwargs passthrough for all providers Resolves initialization order bug where provider kwargs were lost. Runtime kwargs now properly override stored defaults. - Add merge_kwargs() to base class - Filter None values to prevent SDK errors - Support provider-specific params (stop, top_p, top_logprobs) - Add test coverage * Update OpenAI JSON mode to not require fence output
aksg87
added a commit
that referenced
this pull request
Sep 12, 2025
* Fix kwargs passthrough for all providers Resolves initialization order bug where provider kwargs were lost. Runtime kwargs now properly override stored defaults. - Add merge_kwargs() to base class - Filter None values to prevent SDK errors - Support provider-specific params (stop, top_p, top_logprobs) - Add test coverage * Update OpenAI JSON mode to not require fence output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates kwargs handling across all provider models to properly merge stored and runtime parameters. Runtime kwargs take precedence over initialization kwargs, allowing dynamic configuration overrides.
Fixes #136
Bug fix
How Has This Been Tested?
All tests pass including live API and Ollama integration tests:
Checklist:
Code of conduct.
Contributing
page, and I either signed the Google
Individual CLA
or am covered by my company's
Corporate CLA.
issue(s) and we have agreed upon the general approach.
issue(s) that documentation elsewhere needs updating.
Google's Python Style Guide
and ran
pylintover the affected code.