Style guide fixes for PR #119 #120
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace assert with RuntimeError (Style Guide 2.4.4) - Add warning for use_schema_constraints with model/config - Add tests for new warning behavior
|
No linked issues found. Please link an issue in your pull request description or title. Per our Contributing Guidelines, all PRs must:
You can also use cross-repo references like |
6 tasks
mariano
approved these changes
Aug 11, 2025
mariano
added a commit
to mariano/langextract
that referenced
this pull request
Aug 11, 2025
aksg87
pushed a commit
that referenced
this pull request
Aug 11, 2025
* Adding model and config parameters to extract() * Adding extract precedence tests * Applying changes from #120
aksg87
pushed a commit
that referenced
this pull request
Aug 21, 2025
* Adding model and config parameters to extract() * Adding extract precedence tests * Applying changes from #120
sinnaj
pushed a commit
to sinnaj/langextract
that referenced
this pull request
Sep 3, 2025
* Adding model and config parameters to extract() * Adding extract precedence tests * Applying changes from google#120
aksg87
added a commit
that referenced
this pull request
Sep 12, 2025
* Adding model and config parameters to extract() * Adding extract precedence tests * Applying changes from #120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor updates for PR #119 to follow Google Python Style Guide.
Changes:
assertwithRuntimeErrorper Style Guide §2.4.4use_schema_constraintsis used withmodel/configto avoid unexpected behaviorNote: These changes should be incorporated into PR #119 before merging. A more unified schema handling approach will be added in future updates.
cc @mariano (author of PR #119)