Skip to content

Fix agent polling-timeout disablement #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix agent polling-timeout disablement #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions agent/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,12 @@ func pollForNewRequests(pollingCtx context.Context, client *http.Client, hostPro
log.Printf("Request polling context completed with ctx err: %v\n", pollingCtx.Err())
return
default:
listRequestsCtx, cancel := context.WithTimeout(pollingCtx, *proxyTimeout)
defer cancel()
listRequestsCtx := pollingCtx
var cancel context.CancelFunc
if *proxyTimeout > 0 {
listRequestsCtx, cancel = context.WithTimeout(pollingCtx, *proxyTimeout)
defer cancel()
}
if requests, err := utils.ListPendingRequests(listRequestsCtx, client, *proxy, backendID, metricHandler); err != nil {
log.Printf("Failed to read pending requests: %q\n", err.Error())
time.Sleep(utils.ExponentialBackoffDuration(retryCount))
Expand Down