Correct updated return value in UpdateVolumeAnnotations.
#11771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test/cl764585815
branch
3 times, most recently
from
b74d2f4 to
d68bf8f
Compare
`UpdateVolumeAnnotations` was returning `updated = true` even when a mount type was already correct. This avoids unnecessarily overwriting the spec when there are no changes. Also simplify tests. PiperOrigin-RevId: 766710817
copybara-service
bot
force-pushed
the
test/cl764585815
branch
from
d68bf8f to
526bc40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct
updatedreturn value inUpdateVolumeAnnotations.UpdateVolumeAnnotationswas returningupdated = trueeven when amount type was already correct. This avoids unnecessarily overwriting the spec
when there are no changes. Also simplify tests.