Skip to content

Nb updates #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Nb updates #556

merged 2 commits into from
Mar 12, 2025

Conversation

joefernandez
Copy link
Contributor

Description of the change

Notebook updates: Move, add, delete, and modify

Motivation

Maintenance of notebook documentation

Type of change

Documentation

Checklist

  • [x ] I have performed a self-review of my code.
  • [x ] I have added detailed comments to my code where applicable.
  • [x ] I have verified that my change does not break existing code.
  • [x ] My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • [x ] I am familiar with the Google Style Guide for the language I have coded in.
  • [x ] I have read through the Contributing Guide and signed the Contributor License Agreement.

@joefernandez joefernandez requested a review from a team as a code owner March 12, 2025 06:18
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:documentation Update docs labels Mar 12, 2025
Copy link
Contributor

@bebechien bebechien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's fix nbfmt later

@bebechien bebechien merged commit 7868875 into google:main Mar 12, 2025
3 of 5 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Mar 12, 2025
@bebechien
Copy link
Contributor

nvm, actually nbfmt error was coming from the notebooks that has been removed.
I fixed this on gemma-cookbook
google-gemini/gemma-cookbook@9843be9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants