Skip to content

[Swift] Fixes inlining & module importing #8637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

mustiikhalil
Copy link
Collaborator

@mustiikhalil mustiikhalil commented Jul 10, 2025

  • The following PR removed @_exported import in favor of using the default import
  • Fixes a couple of inline functions to only be usable from inline

@github-actions github-actions bot added c++ codegen Involving generating code from schema grpc swift labels Jul 10, 2025
@mustiikhalil mustiikhalil self-assigned this Jul 10, 2025
@mustiikhalil mustiikhalil requested a review from aardappel July 10, 2025 20:36
@mustiikhalil mustiikhalil enabled auto-merge (squash) July 11, 2025 21:45
@mustiikhalil mustiikhalil changed the title [Swift] Imports the Common module directly [Swift] Fixes inlining & module importing Jul 16, 2025
The following moves away from @_exported since it isnt finalized yet,
and is strongly discouraged.

Fixes a couple of @inline(__always) calls within the new flexbuffers
library, and instead attributing them with @usableFromInline
@mustiikhalil mustiikhalil force-pushed the fixes-import-swift-6 branch from 1328dde to dcb2b3e Compare July 16, 2025 15:41
@mustiikhalil
Copy link
Collaborator Author

@aardappel This is ready to be merged! nothing major just force import common (internal module) and fixes inlining some functions.

@mustiikhalil mustiikhalil merged commit 07c2eb5 into google:master Jul 16, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ codegen Involving generating code from schema grpc swift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants