vk: refactor to use polymorphism for platform specialization #9398
+498
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poweifeng
force-pushed
the
pf/vk-refactor-platform
branch
from
2ac7709 to
fc45820
Compare
We refactor VulkanPlatform so that getSwapchainInstanceExtensions() and createVkSurfaceKHR() are virtual functions that are implemented by each platform. This will enable the use of polymorphism for platform-dependent bits.
poweifeng
force-pushed
the
pf/vk-refactor-platform
branch
from
fc45820 to
a9bb51e
Compare
z3moon
reviewed
Nov 4, 2025
| VulkanPlatform::SurfaceBundle VulkanPlatformWindows::createVkSurfaceKHR(void* nativeWindow, | ||
| VkInstance instance, uint64_t flags) const noexcept { | ||
| VkSurfaceKHR surface; | ||
| VkExtent2D extent; |
There was a problem hiding this comment.
Sorry, I should've added more details. I thought this extent needs to be populated with values. Is this method intentionally returning { 0, 0 } for the second element? Then maybe this VkExtent2D extent; can be removed.
There was a problem hiding this comment.
it's not needed for this implementation, but needed for others.
z3moon
approved these changes
Nov 4, 2025
| VulkanPlatform::SurfaceBundle VulkanPlatformWindows::createVkSurfaceKHR(void* nativeWindow, | ||
| VkInstance instance, uint64_t flags) const noexcept { | ||
| VkSurfaceKHR surface; | ||
| VkExtent2D extent; |
There was a problem hiding this comment.
Sorry, I should've added more details. I thought this extent needs to be populated with values. Is this method intentionally returning { 0, 0 } for the second element? Then maybe this VkExtent2D extent; can be removed.
pixelflinger
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We refactor VulkanPlatform so that getSwapchainInstanceExtensions() and createVkSurfaceKHR() are virtual functions that are implemented by each platform. This will enable the use of polymorphism for platform-dependent bits.