-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[depends on #9331] buffer update opt: Integrate UboManager into the engine #9397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
show50726
wants to merge
36
commits into
google:main
Choose a base branch
from
show50726:dev/final-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 49c4a5d.
# Conflicts: # filament/src/details/MaterialInstance.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To focus on the integration logic added in this PR, please ignore
BufferAllocatorandUboManagerand their related tests. They were introduced in the base PR (#9331).Changes
UboManager. It initializes it, calls itsbeginFrame/endFramemethods, and manages MaterialInstance slot retirement on destruction.useUboBatchingflag.commit()now writes data to the shared buffer viauboManager->updateSlot.use()now binds the shared buffer using its dynamic offset.createInstance()methods are updated to pass theuseUboBatchingflag to the MaterialInstance.mi->commit(driver)are updated tomi->commit(driver, mEngine.getUboManager())to pass the manager.endFrame(), it now notifies the UboManager to create a fence for GPU synchronization.DYNAMIC_OFFSETflag for the material's uniform buffer, so that it could update the offset without recreating the descriptor set.