Skip to content

Conversation

@benn-herrera
Copy link

@benn-herrera benn-herrera commented Oct 27, 2025

Add libwebp to third_party

This PR broken out as 2 of 3 from #9363 per request by @pixelflinger

  • Addresses Issue 7962
  • Added third_party/libwebp at version 1.6.0
    • Vast majority of the file changes
  • Added integration in third_party/libwebp/tnt/
  • Added FILAMENT_SUPPORTS_WEBP_TEXTURES cmake build option
    • controls inclusion of third_party/libwebp/tnt
    • adds compile time macro definition FILAMENT_SUPPORTS_WEBP_TEXTURES when ON
    • defaults to OFF


set(WEBP_LINK_STATIC ON)
set(WEBP_ENABLE_SIMD ON)
set(WEBP_USE_THREAD ON)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry that this might force the application that consumes this library (Filament in this case) to always enable multi-thread support.

Some of our WebAssembly users (wasm) may want to disable pthread for their product. In this case, I wonder how this option plays out.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good point. for web assembly builds SIMD shoiuld be off as should thread support.

@benn-herrera benn-herrera requested a review from z3moon October 27, 2025 22:11
@z3moon
Copy link
Contributor

z3moon commented Oct 27, 2025

I'm not sure how WEBGL_PTHREADS is supposed to be set for Filament. But it's outside the scope of this pr.

@benn-herrera
Copy link
Author

benn-herrera commented Oct 28, 2025

Hey, @pixelflinger - I have a branch on my fork ready for opening the last PR adding optional webp texture support here once this PR and #9369 are merged.

@pixelflinger pixelflinger added the internal Issue/PR does not affect clients label Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Issue/PR does not affect clients

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants