-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add Optional Inclusion of libwebp in Third Party Libaries #9371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Optional Inclusion of libwebp in Third Party Libaries #9371
Conversation
|
|
||
| set(WEBP_LINK_STATIC ON) | ||
| set(WEBP_ENABLE_SIMD ON) | ||
| set(WEBP_USE_THREAD ON) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worry that this might force the application that consumes this library (Filament in this case) to always enable multi-thread support.
Some of our WebAssembly users (wasm) may want to disable pthread for their product. In this case, I wonder how this option plays out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a good point. for web assembly builds SIMD shoiuld be off as should thread support.
|
I'm not sure how |
|
Hey, @pixelflinger - I have a branch on my fork ready for opening the last PR adding optional webp texture support here once this PR and #9369 are merged. |
Add libwebp to third_party
This PR broken out as 2 of 3 from #9363 per request by @pixelflinger