vk: fix update after bind (wrt descriptor set) validation error #9251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
but if the image changed its colorspace, wouldnt that mean we got a new texture called with setParameter (not in the stream) which implies the frontend will create a new descriptor set? |
pixelflinger
approved these changes
Sep 24, 2025
| mPipelineState.bindInDraw.first = false; | ||
| } | ||
| mDescriptorSetCache.commit(mCurrentRenderPass.commandBuffer, mPipelineState.pipelineLayout, | ||
| mDescriptorSetCache.commit(bufferHolder, mPipelineState.pipelineLayout, |
There was a problem hiding this comment.
is there a way this could behind a very fast "if unlikely"? I feel like commit is pretty heavy.
In filament, once a descriptor set is bound, we no longer make updates to it. However, this guarrantee was broken in the external sampler/image because a colorspace change might necessitate a layout change, and thereby a new descriptor needs to be generated with the appropriate externally sampled image updated in the new set. Another use case is the Stream API, where each frame we might be getting a different AHardwareBuffer, meaning we need to update one or multiple sampler bindings in a set that might have been bound in a previous frame. In this change, we always create a new set when there's a change in the image currently bound to an existing set (while accounting for whether we need to use a new externally sampled layout or not).
poweifeng
force-pushed
the
pf/vk-ext-img-fix-ref
branch
from
aef3d1d to
77b9913
Compare
rafadevai
reviewed
Sep 30, 2025
| fvkmemory::resource_ptr<VulkanDescriptorSetLayout> layout, | ||
| OnRecycle&& onRecycleFn, VkDescriptorSet vkSet); | ||
|
|
||
| // NOLINTNEXTLINE(bugprone-exception-escape) |
There was a problem hiding this comment.
no need for this anymore?
pixelflinger
approved these changes
Oct 3, 2025
phoenixxxx
approved these changes
Oct 21, 2025
rafadevai
suggested changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In filament, once a descriptor set is bound, we no longer make updates
to it. However, this guarrantee was broken in the external sampler/image
because a colorspace change might necessitate a layout change, and
thereby a new descriptor needs to be generated with the appropriate
externally sampled image updated in the new set.
Another use case is the Stream API, where each frame we might be
getting a different AHardwareBuffer, meaning we need to update one
or multiple sampler bindings in a set that might have been bound in
a previous frame.
In this change, we always create a new set when there's a change
in the image currently bound to an existing set (while accounting for
whether we need to use a new externally sampled layout or not).