Skip to content

Metal: use atomic for buffer tracking #9237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Metal: use atomic for buffer tracking #9237

wants to merge 1 commit into from

Conversation

@bejado
Copy link
Member

@bejado bejado commented Sep 19, 2025

BUGS = [438574508]

@bejado bejado added the internal Issue/PR does not affect clients label Sep 19, 2025
pixelflinger
pixelflinger requested changes Sep 19, 2025
View reviewed changes
Copy link
Collaborator

@pixelflinger pixelflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think those should be static. There could be several instances of filament in the process.

In fact we should review all static variables usage.

It would be preferable that those live in MetalDriver or MetalContext.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pixelflinger pixelflinger pixelflinger requested changes

@z3moon z3moon z3moon approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@pixelflinger pixelflinger

@z3moon z3moon

@poweifeng poweifeng

Labels

internal Issue/PR does not affect clients

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bejado @pixelflinger @z3moon @poweifeng