Add defines to strip unused default materials #8723
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add defines for trimming default materials. These enable binary size reduction by omitting them. Referencing the trimmed material will cause associated renderables to be skipped from rendering. BUG=[415840223]
bejado
reviewed
May 12, 2025
| @@ -468,12 +468,16 @@ RenderableManager::Builder::Result RenderableManager::Builder::build(Engine& eng | |||
| auto& entry = mImpl->mEntries[i]; | |||
|
|
|||
| // entry.materialInstance must be set to something even if indices/vertices are null | |||
There was a problem hiding this comment.
Is this comment still valid? If FILAMENT_TRIM_DEFAULT_MATERIAL is set then entry.materialInstance could end up null. Will that cause a crash later on?
There was a problem hiding this comment.
I believe this will be handled in FRenderPrimitive::init in filament/src/RenderPrimitive.cpp. (above)
But the comment needs to be updated accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add defines for trimming default materials. These enable binary size reduction by omitting them. Referencing the trimmed material will cause associated renderables to be skipped from rendering.
BUG=[415840223]