Update Gitignore to ignore generated files. #8624
Conversation
| build/.cmake/ | ||
| build/CMakeCache.txt | ||
| build/CMakeFiles/ | ||
| build/Makefile | ||
| build/SPIRV-Tools* | ||
| build/cmake_install.cmake | ||
| build/compile_commands.json | ||
| build/filament/ | ||
| build/include/ | ||
| build/libs/ | ||
| build/mac/ninja | ||
| build/samples/ | ||
| build/shaders/ | ||
| build/third_party/ | ||
| build/tools/ |
There was a problem hiding this comment.
any reason to not put all of build/** in the gitignore?
There was a problem hiding this comment.
The build folder has quite a few things checked in already, https://github.com/google/filament/tree/main/build
This overloading means that to ignore only the generated files I need to be specific.
There was a problem hiding this comment.
@bridgewaterrobbie is this useful for you because your CLion CMake profile(s) uses "build" as your "Build directory" setting vs. the default cmake-build-...? Or accounting for folks that might do that?
There was a problem hiding this comment.
No it isn't due to changes to my cmake.
I believe my initial post about the source of these files may be wrong and it is not from CLion builds (Though I'd still like this), I think this came about from me locally running CI checks to validate my changes before pushing. IMO this is still nice to have as that should be a good practice.
There was a problem hiding this comment.
ah CI checks, that makes sense 👍 Yes, "build" is a very common name for the build directory of a CMake project, agreed :)
There was a problem hiding this comment.
There are a few things that can put output here I think, but one example iis
cd build/mac
./build.sh presubmit
IE just me copying https://github.com/google/filament/blob/main/.github/workflows/presubmit.yml#L27
There was a problem hiding this comment.
So interestingly, I ran that CI, and the only one that showed up is build/mac/ninja and I think it might make sense to move that to a github action as oppose to using an explicit script.
There was a problem hiding this comment.
I can take that as an AI.
There was a problem hiding this comment.
@bridgewaterrobbie , I cleaned up a lot of the CI stuff, and running these scripts shouldn't add anything to the build folder anymore. Would you mind checking?
If no unintended artifacts are generated by running CI scripts locally, then I propose we do not add these gitignore entries. Please let me know if you have a different thought on this. Thanks.
There was a problem hiding this comment.
Yep, this looks good now in my testing. Thank you @poweifeng
bridgewaterrobbie
force-pushed
the
gitIgnoreUpdate
branch
from
2d6e0d1 to
9a74936
Compare
No description provided.