Add ability to play animations on a separate instance #7919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@mentholyspirit could sigh the CLA so we could submit the change eventually? |
mentholyspirit
force-pushed
the
feature/reusable-animation
branch
2 times, most recently
from
0975047 to
8f617eb
Compare
|
Signed the CLA |
pixelflinger
requested changes
Jun 18, 2024
There was a problem hiding this comment.
new ctor should not be inline and should be clearly documented.
lifetime management of the Animator on the java side seems sketchy to me, I'll defer to @romainguy here.
android/gltfio-android/src/main/java/com/google/android/filament/gltfio/Animator.java
Outdated
Show resolved
Hide resolved
mentholyspirit
force-pushed
the
feature/reusable-animation
branch
from
58fb7f2 to
a1be171
Compare
romainguy
suggested changes
Jul 19, 2024
android/gltfio-android/src/main/java/com/google/android/filament/gltfio/Animator.java
Outdated
Show resolved
Hide resolved
android/gltfio-android/src/main/java/com/google/android/filament/gltfio/Animator.java
Outdated
Show resolved
Hide resolved
mentholyspirit
force-pushed
the
feature/reusable-animation
branch
from
0d1e946 to
914998f
Compare
mentholyspirit
force-pushed
the
feature/reusable-animation
branch
from
914998f to
bf89e17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #7622