fix: Use klog for NRI library logging #252
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NRI library uses its own logger interface, which defaults to logrus. To ensure consistent logging with the rest of the dranet components that use klog, this change introduces a klog-based logger for NRI.
michaelasp
reviewed
Oct 10, 2025
| logger klog.Logger | ||
| } | ||
|
|
||
| func (l *nriLogger) Debugf(ctx context.Context, format string, args ...interface{}) { |
There was a problem hiding this comment.
Why do we need contexts for these? I don't see that in klog from what I can tell, e.g https://pkg.go.dev/k8s.io/klog/v2#Errorf
There was a problem hiding this comment.
AFAIK klog and logr normally take context on constructing a logger, not on individual logf style calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NRI library uses its own logger interface, which defaults to logrus. To ensure consistent logging with the rest of the dranet components that use klog, this change introduces a klog-based logger for NRI.
Depends on containerd/nri#239 to take affect (but doesn't break in it's absence)