Small fixes to concurrency material #2737
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fw-immunant
force-pushed
the
fw/concurrency-fixes
branch
from
ab4a5dc to
ac18f49
Compare
djmitche
approved these changes
May 5, 2025
fw-immunant
force-pushed
the
fw/concurrency-fixes
branch
2 times, most recently
from
59f3ab3 to
ae231ce
Compare
Ownership is the responsibility to free a value. Previously, `v` was always freed by the main thread because it kept the original `Arc` instance. It was difficult to explain why this example did not simply use scoped threads instead. Now we see that multi-threaded dynamic ownership with `Arc` results in a dynamic decision of which thread will clean up a given value.
fw-immunant
force-pushed
the
fw/concurrency-fixes
branch
from
ae231ce to
683271a
Compare
fw-immunant
force-pushed
the
fw/concurrency-fixes
branch
from
683271a to
6e92ef1
Compare
|
Can someone merge without squashing? |
|
Looks like I can only "Squash and merge" -- I assume an admin is required to override that. |
|
@mgeisler probably has the power |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.