fix: when converting the llm_request to JSON, skip non-serializable data #879
+66
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selcukgun
reviewed
May 23, 2025
tests/unittests/test_telemetry.py
Outdated
|
|
||
| async def _create_invocation_context( | ||
| agent: LlmAgent, state: Optional[dict[str, Any]] = None | ||
| ) -> ReadonlyContext: |
There was a problem hiding this comment.
please replace the return type:
ReadonlyContext -> InvocationContext
There was a problem hiding this comment.
Sounds good, will do!
selcukgun
suggested changes
May 23, 2025
selcukgun
reviewed
May 23, 2025
tests/unittests/test_telemetry.py
Outdated
|
|
||
| from google.adk.sessions import InMemorySessionService | ||
| from google.adk.agents.invocation_context import InvocationContext | ||
| from google.adk.agents.readonly_context import ReadonlyContext |
There was a problem hiding this comment.
nit: import not needed anymore.
There was a problem hiding this comment.
Whoops, good catch; fixed
selcukgun
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #878
When converting the
llm_requestto JSON, the code in this PR adds skipping of non-serializable data.testing plan
unit test
Added unit test.
manual e2e test
Followed To reproduce steps from #878 -- agent responds without crashing.
