fix: when converting the llm_request to JSON, skip non-serializable data #879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selcukgun
reviewed
May 23, 2025
selcukgun
requested changes
May 23, 2025
selcukgun
reviewed
May 23, 2025
selcukgun
approved these changes
May 23, 2025
hangfei
approved these changes
May 27, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
May 27, 2025
-- b781880 by Stephen Smith <stephen.smith@newfront.com>: Telemetry unit test for non-serializable data. -- 179da9d by Stephen Smith <stephen.smith@newfront.com>: When converting the llm_request to JSON, skip non-serializable data. -- 5dc68f4 by Stephen Smith <stephen.smith@newfront.com>: Update _create_invocation_context() return type to InvocationContext. -- 23a33f7 by Stephen Smith <stephen.smith@newfront.com>: Oops, remove unnecessary import. COPYBARA_INTEGRATE_REVIEW=#879 from stephensmithnewfront:main f71e195 PiperOrigin-RevId: 763922003
|
merge completed by copybara. |
coder-aditi
pushed a commit
to coder-aditi/adk-python
that referenced
this pull request
Jul 2, 2025
-- b781880 by Stephen Smith <stephen.smith@newfront.com>: Telemetry unit test for non-serializable data. -- 179da9d by Stephen Smith <stephen.smith@newfront.com>: When converting the llm_request to JSON, skip non-serializable data. -- 5dc68f4 by Stephen Smith <stephen.smith@newfront.com>: Update _create_invocation_context() return type to InvocationContext. -- 23a33f7 by Stephen Smith <stephen.smith@newfront.com>: Oops, remove unnecessary import. COPYBARA_INTEGRATE_REVIEW=google#879 from stephensmithnewfront:main f71e195 PiperOrigin-RevId: 763922003
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #878
When converting the
llm_requestto JSON, the code in this PR adds skipping of non-serializable data.testing plan
unit test
Added unit test.
manual e2e test
Followed To reproduce steps from #878 -- agent responds without crashing.
