-
Notifications
You must be signed in to change notification settings - Fork 2k
Bump models in llms and llms-full to Gemini 2.5 #3166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @ggalloro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the underlying large language models used by various agents within the system. By bumping the model version from Gemini 2.0 Flash to Gemini 2.5 Flash, the agents are expected to benefit from improved performance and capabilities offered by the newer model iteration, ensuring the system leverages the latest advancements in Google's AI technology. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the model name in the documentation examples from gemini-2.0-flash
to gemini-2.5-flash
. The changes in llms.txt
are correct and align with the PR's goal. I have one suggestion to improve the maintainability of the code examples. Additionally, the PR title suggests a broader scope ('llms and llms-full'). To ensure consistency, it would be beneficial to check if other parts of the codebase, such as integration tests that still use older model versions, should also be updated as part of this change.
greeter = LlmAgent(name="greeter", model="gemini-2.5-flash", ...) | ||
task_executor = LlmAgent(name="task_executor", model="gemini-2.5-flash", ...) | ||
|
||
# Create parent agent and assign children via sub_agents | ||
coordinator = LlmAgent( | ||
name="Coordinator", | ||
model="gemini-2.0-flash", | ||
model="gemini-2.5-flash", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve the maintainability of this code example, consider defining the model name as a constant at the start of the snippet. The model name gemini-2.5-flash
is used multiple times here. Using a constant would prevent potential inconsistencies and make future updates easier.
For example:
MODEL_NAME = "gemini-2.5-flash"
# Define individual agents
greeter = LlmAgent(name="greeter", model=MODEL_NAME, ...)
task_executor = LlmAgent(name="task_executor", model=MODEL_NAME, ...)
# Create parent agent and assign children via sub_agents
coordinator = LlmAgent(
name="Coordinator",
model=MODEL_NAME,
...
)
No description provided.