fix(code-executor): resolve deepcopy recursion in VertexAiCodeExecutor #1762
+248
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaterlucas
changed the title
Add __deepcopy__ method to handle extension serialization during agent deployment. Extension gets re-initialized automatically when needed. Fixes agent engine deployment failures.
slaterlucas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running code like attached in the first screenshot where we are trying to use an agent engine with the vertex ai code executor, we encountered a recursion issue because the extension object couldn't be deep copied. Added a deepcopy
method that temporarily removes the extension during copy and re-initializes it when needed. This fixed the issue and allowed for creation of an agent engine with the VertexAICodeExecutor. Started working on it after experiencing it myself and seeing this issue #1730 .