fix(llm): handle ConnectionClosedOK exception in _receive_from_model test #1752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
/recheck |
coder-aditi
force-pushed
the
fix/llm_flow_tests
branch
3 times, most recently
from
2894065 to
e67ae95
Compare
coder-aditi
force-pushed
the
fix/llm_flow_tests
branch
from
e67ae95 to
cd43fdb
Compare
coder-aditi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1748
I fixed the failing test test_receive_from_model_yields_events by updating how the ConnectionClosedOK exception is raised. The test was missing required arguments for the exception, which caused errors when running the tests. Now it properly includes those parameters, so the test can simulate a closed connection without breaking. This should make the tests pass smoothly.