feat: cli funcionality to deploy an Agent to a running GKE cluster #1607
+1,299
−355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sry i miss clicked "Ready to review". I can't unclick it. If it's not ready, please unclick from your side. |
|
Yes, It's ready to be reviewed @hangfei , thanks! |
hangfei
reviewed
Jun 26, 2025
|
@hangfei ping |
|
@hangfei is there any blocker to merging this? |
|
LGTM. @vicentefb Could you update the manual e2e testing(GKE, CloudRun) you have done? Please squash into single commit. |
vicentefb
force-pushed
the
GkeDeployAgent
branch
3 times, most recently
from
bb13f0b to
7b1571b
Compare
hangfei
approved these changes
Jul 16, 2025
hangfei
added
the
ready to pull
vicentefb
force-pushed
the
GkeDeployAgent
branch
2 times, most recently
from
e8f3aca to
4f4e1b9
Compare
hangfei
removed
the
ready to pull
vicentefb
force-pushed
the
GkeDeployAgent
branch
2 times, most recently
from
f892762 to
86911b4
Compare
hangfei
approved these changes
Jul 18, 2025
hangfei
added
the
ready to pull
vicentefb
force-pushed
the
GkeDeployAgent
branch
2 times, most recently
from
ab735df to
3fa5cc2
Compare
|
Anything stopping us from merging this? |
hangfei
removed
the
ready to pull
vicentefb
force-pushed
the
GkeDeployAgent
branch
2 times, most recently
from
73329dc to
c829547
Compare
hangfei
approved these changes
Jul 24, 2025
hangfei
added
the
ready to pull
feat: cli funcionality to deploy an Agent to a running GKE cluster feat: cli funcionality to deploy an Agent to a running GKE cluster added tests for tools click adn cli deploy revert some changes on cli tools click added test for tools click fixed lint issues removed eval storage uri scope for now addressed comments on allow origins and nits formatting improved logging and updated tests added label to deployment so that we can keep track in keywords pipeline added labels to pod spec fixing conflicts when rebasing solving conflicts and log_level updated test pylint feat: cli funcionality to deploy an Agent to a running GKE cluster added tests for tools click adn cli deploy revert some changes on cli tools click added test for tools click fixed lint issues removed eval storage uri scope for now addressed comments on allow origins and nits formatting improved logging and updated tests added label to deployment so that we can keep track in keywords pipeline added labels to pod spec fixing conflicts when rebasing solving conflicts and log_level updated test pylint test not working locally feat: cli funcionality to deploy an Agent to a running GKE cluster feat: cli funcionality to deploy an Agent to a running GKE cluster feat: cli funcionality to deploy an Agent to a running GKE cluster added tests for tools click adn cli deploy revert some changes on cli tools click added test for tools click fixed lint issues removed eval storage uri scope for now addressed comments on allow origins and nits formatting improved logging and updated tests added label to deployment so that we can keep track in keywords pipeline added labels to pod spec fixing conflicts when rebasing solving conflicts and log_level updated test pylint feat: cli funcionality to deploy an Agent to a running GKE cluster added tests for tools click adn cli deploy revert some changes on cli tools click added test for tools click fixed lint issues removed eval storage uri scope for now addressed comments on allow origins and nits formatting improved logging and updated tests added label to deployment so that we can keep track in keywords pipeline added labels to pod spec fixing conflicts when rebasing solving conflicts and log_level updated test pylint test not working locally updated test based on merge conflict feat: cli funcionality to deploy an Agent to a running GKE cluster feat: cli funcionality to deploy an Agent to a running GKE cluster feat: cli funcionality to deploy an Agent to a running GKE cluster added tests for tools click adn cli deploy revert some changes on cli tools click added test for tools click fixed lint issues removed eval storage uri scope for now addressed comments on allow origins and nits formatting improved logging and updated tests added label to deployment so that we can keep track in keywords pipeline added labels to pod spec fixing conflicts when rebasing solving conflicts and log_level updated test pylint feat: cli funcionality to deploy an Agent to a running GKE cluster added tests for tools click adn cli deploy revert some changes on cli tools click added test for tools click fixed lint issues removed eval storage uri scope for now addressed comments on allow origins and nits formatting improved logging and updated tests added label to deployment so that we can keep track in keywords pipeline added labels to pod spec fixing conflicts when rebasing solving conflicts and log_level updated test pylint test not working locally feat: cli funcionality to deploy an Agent to a running GKE cluster feat: cli funcionality to deploy an Agent to a running GKE cluster feat: cli funcionality to deploy an Agent to a running GKE cluster added tests for tools click adn cli deploy revert some changes on cli tools click added test for tools click fixed lint issues removed eval storage uri scope for now addressed comments on allow origins and nits formatting improved logging and updated tests added label to deployment so that we can keep track in keywords pipeline added labels to pod spec fixing conflicts when rebasing solving conflicts and log_level updated test pylint feat: cli funcionality to deploy an Agent to a running GKE cluster added tests for tools click adn cli deploy revert some changes on cli tools click added test for tools click fixed lint issues removed eval storage uri scope for now addressed comments on allow origins and nits formatting improved logging and updated tests added label to deployment so that we can keep track in keywords pipeline added labels to pod spec fixing conflicts when rebasing solving conflicts and log_level updated test pylint test not working locally updated test based on merge conflict fixed cli deploy test
vicentefb
force-pushed
the
GkeDeployAgent
branch
from
c680cab to
b3e5e6d
Compare
hangfei
removed
the
ready to pull
hangfei
approved these changes
Jul 24, 2025
hangfei
added
the
ready to pull
hangfei
approved these changes
Jul 24, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 24, 2025
Merge #1607 - Added CLI functionality so that we can deploy and Agent onto a GKE cluster - Related documentation google/adk-docs#445 COPYBARA_INTEGRATE_REVIEW=#1607 from vicentefb:GkeDeployAgent 42f35d9 PiperOrigin-RevId: 786857789
|
merged by copybara. thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.