Nightly lints from more recent nightly

[kaczmarczyck]

Addresses the last comment on #747 . Plus a bit more, my local nightly wasn't fully up to date.

[gemini-code-assist]

Summary of Changes

Hello @kaczmarczyck, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've made a series of small but important updates across the codebase to align with more recent Rust nightly linting rules. Specifically, these changes involve explicitly adding the '_ lifetime specifier to several function signatures where the compiler now requires it for lifetime elision. This ensures that the code remains compatible with the latest nightly toolchains and passes all relevant lints, addressing previous feedback and bringing my local environment up to date.

Highlights

• Explicit Lifetime for Writer: I've updated the new function in libraries/cbor/src/writer.rs to explicitly specify the elided lifetime '_ for the Writer type in its return signature.
• Explicit Lifetime for ProcessedPacket: I've modified the process_single_packet function in libraries/opensk/src/ctap/hid/mod.rs to include the explicit elided lifetime '_ for the ProcessedPacket type in its return signature.
• Explicit Lifetime for Cow: I've updated the read_slice function in src/env/tock/phantom_buffer_storage.rs to explicitly specify the elided lifetime '_ for the Cow type in its return signature.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses lints from a more recent Rust nightly compiler by making elided lifetimes explicit in function return types. The changes in cbor/src/writer.rs, opensk/src/ctap/hid/mod.rs, and env/tock/phantom_buffer_storage.rs are correct and improve code clarity. The overall code quality is high, and I have no further suggestions. The changes look good to merge.

[coveralls]

coverage: 97.15%. remained the same
when pulling 6eed52e on kaczmarczyck:clippy-nightly
into f8824ab on google:develop.