Avoid encoding empty titlePg values #72
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into an issue where taking a human-crafted word doc and modifying it with godocx would then lead to godocx not being able to parse the document, citing:
I tracked this back to the
TitlePGfield onctypes.SectionProp. Prior to modification by godocx, this was encoded as:After modification with godocx, this would be encoded as:
The empty string in Val would cause decoding to fail.
This PR fixes the issue, however, I am not sure this is the fully correct way to go.
Many
*OnOfffields are just that (pointer to OnOff), butTitlePGis*GenSingleStrVal[stypes.OnOff]andGenSingleStrValencodes regardless of whether the value it stores is empty. Rather than modifyingGenSingleStrVal, which would probably break things, I opted to just not encode TitlePG when it is empty. Let me know if there's a better way to handle this.Thanks!